This repository has been archived by the owner on May 25, 2023. It is now read-only.
Added Phase and Conditions to PodGroup.Status struct #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
|
/assign @k82cn |
k8s-ci-robot
added
size/L
|
@k82cn Hi, can you provide some review please, notes, comments are welcome. |
Zyqsempai
force-pushed
the
add-phase-conditions-to-pod-group-status
branch
from
4e9be66 to
d87cf2d
Compare
k8s-ci-robot
added
size/M
Zyqsempai
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Please use |
3 tasks
Edited PR Autogenerated update
Zyqsempai
force-pushed
the
add-phase-conditions-to-pod-group-status
branch
from
d87cf2d to
bb85483
Compare
|
@k82cn Done |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, Zyqsempai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
…nditions-to-pod-group-status Added Phase and Conditions to PodGroup.Status struct
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
…nditions-to-pod-group-status Added Phase and Conditions to PodGroup.Status struct
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
…nditions-to-pod-group-status Added Phase and Conditions to PodGroup.Status struct
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add additional info fields for PodGroup.Status struct to get have more explicit info Status itself
Which issue(s) this PR fixes
#521
Special notes for your reviewer:
Two new fields: Phase and Conditions based on the same fields in the Pod.Status struct
Release note:
NONE